Sometimes iCloud settings takes a little while after switching them on/off before going into work. iCloud Photo Library, moreover, relies on the syncing of all your photos on the cloud, and that too can take a while. To be sure everything goes on fine, try restarting your device, and then applying again the changes. For good measure, wait a little after turning on the switch, and then see if the Library is active