if I use apple music for a year or so and then go on holiday (going for a year) and need to cancel my subscription does the music I have downloaded from apple music stay on my device?
Music you've downloaded from Apple Music appears in a different folder on your desktop. Your own music is in the 'Music' and music from Apple Music is in the 'Apple Music' folder.
You will only lose files in the Apple Music folder