Re: My settings are correct for icloud on my phone but in the files app there are no pictures etc.
Initiate the Photos app. All of the pics that are on your device should be synced to iCloud. Backups of your photos will not natively appear in the Files app.